Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CommandGoToOtherEndOfHiglightedText - #526 #539

Merged
merged 4 commits into from
Aug 2, 2016
Merged

Added CommandGoToOtherEndOfHiglightedText - #526 #539

merged 4 commits into from
Aug 2, 2016

Conversation

Platzer
Copy link
Contributor

@Platzer Platzer commented Jul 29, 2016

Sry, i tried to fix #526 but i'm not a typescript nor js nor web developer and not really familiar with github pull request and your contribution guidelines. Just take a look, its a simple fix but i'm not sure if i created any side-effects.

@@ -1194,6 +1194,22 @@ class CommandUnfoldAll extends BaseCommand {
}

@RegisterAction
class CommandGoToOtherEndOfHighlightedText extends BaseCommand {
modes = [ModeName.Visual];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include ModeName.VisualLine as well?

@rebornix
Copy link
Member

@Platzer you are really doing good and thanks!

@Platzer
Copy link
Contributor Author

Platzer commented Aug 1, 2016

Applied all changes, thx for your feedback!

@johnfn johnfn merged commit 12d7927 into VSCodeVim:master Aug 2, 2016
@johnfn
Copy link
Member

johnfn commented Aug 2, 2016

A two line function body. That's what I like to see. Beautiful!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual mode: "o" - move to other end of marked area
3 participants