Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute with no range or marks #525

Merged
merged 3 commits into from
Aug 8, 2016

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Jul 27, 2016

  • Commit message has a short title & issue references
  • Each commit does a logical chunk of work.
  • It builds and tests pass (e.g gulp tslint)

Fix #512.

We support followings substitute commands

  • :s/old/new/flags
  • '<,'>s/old/new/flags

@johnfn
Copy link
Member

johnfn commented Jul 29, 2016

The way that it works in vim is if you have a selection, Vim automatically inserts '<,'>, which means "run this ex command on a selection." However, you can backspace that and run an ex command not on a selection, if you made a mistake.

Would it be possible to insert those characters into the ex command line in vscode only if there's a selection, then check for them (rather than the existence of a selection) to see if the ex command operates on a selection or not?

@rebornix
Copy link
Member Author

@johnfn yeah, I didn't implement <> in the first beginning. Let me bring it in.

@rebornix rebornix changed the title Substitute with no range Substitute with no range or marks Aug 2, 2016
@rebornix
Copy link
Member Author

rebornix commented Aug 2, 2016

Support subsitution with no range or marks (now we only support '< and '>).

@johnfn
Copy link
Member

johnfn commented Aug 5, 2016

@rebornix is this done? sorry, i think i missed your previous message!

@rebornix
Copy link
Member Author

rebornix commented Aug 5, 2016

yup, it contains everything in description.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants