Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command line mode refactoring #5

Merged
merged 3 commits into from
Nov 16, 2015
Merged

command line mode refactoring #5

merged 3 commits into from
Nov 16, 2015

Conversation

guillermooo
Copy link
Member

Refactoring for simpler code. (I hope.)

@guillermooo guillermooo changed the title command line mode command line mode refactoring Nov 16, 2015
@jpoon
Copy link
Member

jpoon commented Nov 16, 2015

@guillermooo would you mind squashing your commits? git rebase -i HEAD~10 to squash the last 10 commits.

@guillermooo
Copy link
Member Author

sure

@guillermooo
Copy link
Member Author

@jpoon I still have a bunch of default headers and tabs in the files. I can try cleaning that up and squashing again. Or do it later.

@jpoon
Copy link
Member

jpoon commented Nov 16, 2015

I'm a neat freak so I setup gulp+tslint on a private branch and we have a bunch of errors :(. Didn't bother with fixing them as (1) there were a lot and (2) Connect() is coming up fast.

We can start taking care of the engineering debt when we have some basic stuff working?

@guillermooo
Copy link
Member Author

I'm learning TS as I go, so you better wait some more. :) So 👍 to paying debt off later. When we look into that, we should setup CI integration with Travis and Appveyor to run the test suite. I suppose we can output the test results to a file somehow.

I will try to fix the basic stuff such as whitespace now, though.

@guillermooo
Copy link
Member Author

Well, I took a look at tslint issues and actually fixed them already.

@jpoon
Copy link
Member

jpoon commented Nov 16, 2015

👍 Feel free to merge. I believe you should have that green button enabled.

guillermooo added a commit that referenced this pull request Nov 16, 2015
command line mode refactoring
@guillermooo guillermooo merged commit 974dab8 into master Nov 16, 2015
@guillermooo guillermooo deleted the ex-mode branch November 17, 2015 07:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants