Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #338 - add gt, gT support #482

Merged
merged 1 commit into from
Jul 23, 2016
Merged

Fix #338 - add gt, gT support #482

merged 1 commit into from
Jul 23, 2016

Conversation

arussellk
Copy link
Contributor

I did not write tests for this since the existing, closely-related actions MoveToRightPane and MoveToLeftPane did not have tests.

Let me know if anything looks wrong.

@rebornix
Copy link
Member

I suppose this is about tabs, not editor groups, right? We are mapping editor groups to Vim's Window concept. For moving Tabs, you need to use other API, take a look at https://github.com/VSCodeVim/Vim/blob/master/src/cmd_line/commands/tab.ts . We've already had commands for them, and the logic is similar.

BTW, no worries about test cases of Tab, it's not testable with current test infra.

Refactor gt, gT to use existing tab commands
@arussellk
Copy link
Contributor Author

@rebornix I rewrote my code to use the existing tab stuff. Check it out.

@johnfn
Copy link
Member

johnfn commented Jul 23, 2016

LGTM! Thanks for the PR, @arussellk!

@johnfn johnfn merged commit 8762a8d into VSCodeVim:master Jul 23, 2016
@arussellk arussellk deleted the Fix#338 branch July 27, 2016 22:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants