Fix regressions in text objects #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to the Bram Moolenaar fan club 😉 |
|
I understand the thing about not being easy to test < or >. Eventually I want to tokenize all characters just how Vim does, so there's no confusion. Then < will become |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression in text objects when positioned over the final character.
It also fixes a regression with
<objects, which is unfortunately not easy to test right now due to the way test cases are tokenized. I'd like to follow up and make it testable and add the appropriate tests, but I also want to leave master in a stable state.I am starting to appreciate just how much vim does under the hood :)