Add support for failed motions #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| // Make sure the start position is inside the selection | ||
|
|
||
| if (startPos.isAfter(position) || endPos.isBefore(position)) { |
There was a problem hiding this comment.
We can remove this now, right?
| @@ -707,6 +707,10 @@ export class ModeHandler implements vscode.Disposable { | |||
| if (result instanceof Position) { | |||
| vimState.cursorPosition = result; | |||
| } else if (isIMovement(result)) { | |||
| if (result.failed) { | |||
| vimState.recordedState = new RecordedState(); | |||
There was a problem hiding this comment.
I believe this is the line that is causing #474, since the stacktrace we're getting is coming from modeHandler.ts:
if (!recordedState.operator) {
throw new Error("what in god's name");
}
But more guessing than actually understanding what "recorded state" is.
There was a problem hiding this comment.
Yeah, sorry, RecorededState is an awful name! It used to be called ActionState, which was a little better, but still bad.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's always a pleasant thing when a change that seems tricky ends up being very simple. 😃
Fixes a bug I promised @sectioneight I'd get to where ci{ when you're not inside {} would cause you to switch into insert mode. Also fixes an old bug where dtx when x couldn't be found would delete a character.