Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixTabStops #461

Merged
merged 1 commit into from
Jul 17, 2016
Merged

FixTabStops #461

merged 1 commit into from
Jul 17, 2016

Conversation

rebornix
Copy link
Member

Yay! We love PRs! 🎊

Please include a description of your change & check your PR against this list, thanks:

  • Commit message has a short title & issue references
  • Commits are squashed
  • It builds and tests pass (e.g gulp tslint)

Since this configuration is not accessible in vscode 1.0.0, we can't write test cases for it currently. So I just tested manually for now. A proper workaround is adding a test folder for testing (mentioned this before with @johnfn ) or waiting for VS Code's July release.

@rebornix
Copy link
Member Author

Fixes #448.

@johnfn
Copy link
Member

johnfn commented Jul 16, 2016

Fix the merge conflicts and we should be good to go.

The more of the VSC insert algo that we replicate inside InsertInInsertMode, the sadder I get. Those API extensions can't come soon enough. 😛

@rebornix
Copy link
Member Author

Fix conflicts. It's almost the first thing I need to do after I wake up every day :)

I have a bad feeling about VSC stuff as well. While fixing bugs for CJK and a few other bugs, I found these bugs only exist in our code base but not am-vim or Alex's Vim prototype, and that's because we are handling the cursor position ourselves while they are delegating Insert/Delete in Insert Mode directly to VS Code. Not sure if there will be other hidden problems about the cursor problem any more but if it happens again, I'd like to further investigate.

@johnfn
Copy link
Member

johnfn commented Jul 17, 2016

Unfortunately the cursor tracking is necessary for a number of things we do that amVim and the other Vim prototypes don't do - the most notable of which is history tracking.

@johnfn
Copy link
Member

johnfn commented Jul 17, 2016

Sorry about making you fix all the conflicts though haha. If only this project wasn't so active... sigh... 😉

@johnfn johnfn merged commit 0d638f9 into VSCodeVim:master Jul 17, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants