Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back missing control-c registration #455

Merged
merged 1 commit into from
Jul 16, 2016

Conversation

ascandella
Copy link
Contributor

Looks like this was accidentally removed in #445

Looks like this was accidentally removed in VSCodeVim#445
@rebornix
Copy link
Member

LGTM. This might happen as Git Diff looks always weird when adding new actions.

@ascandella
Copy link
Contributor Author

Yea, this is what the diff looks like for that PR:

image

You can see ControlC is now orphaned without a decorator (is that what they're called in TS?)

@rebornix
Copy link
Member

Yup, that's Decorator and @johnfn said we had some problems with it and that's why we have to put every command in one single file.

image

See image above, if we add a new command starting with @RegisterAction, Git will not treat the first line as add, instead it will make the @RegisterAction after your change as add, which is weird to me and sometimes I revert the last line by mistake.

@jpoon jpoon merged commit cbb0d49 into VSCodeVim:master Jul 16, 2016
@jpoon
Copy link
Member

jpoon commented Jul 16, 2016

Thanks @sectioneight for the fix

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants