reorganize tests; add tests #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillermooo
force-pushed
the
more-tests
branch
from
8154a69
to
c6581a0
Compare
|
@jpoon Is perhaps the node_js version in Appveyor or Travis yml wrong? |
guillermooo
force-pushed
the
more-tests
branch
from
c6581a0
to
7ec07e0
Compare
|
Thanks so much for this! I had the exact same change earlier today :) Node version is set to "0.12". Electron actually uses: The tests were previously passing? |
Note that they are passing for appveyor. The failing test is new or modified. |
|
Feel free to update the node version on travis.yml to make the tests pass. |
|
👍 they pass! |
guillermooo
force-pushed
the
more-tests
branch
from
afc26cb
to
3f2c6b5
Compare
|
🎈 |
guillermooo
added a commit
that referenced
this pull request
Nov 28, 2015
reorganize tests; add tests
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.