Read TextEditor options from active editor #444
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay! We love PRs! 🎊
Please include a description of your change & check your PR against this list, thanks:
gulp tslint
)We were reading TextEditor options from configuration but there are some drawbacks:
vscode.window.activeTextEditor.options
through API on the fly, it's not synced back tovscode.workspace.getConfiguration("editor")
. It does make sense becausevscode.workspace.getConfiguration("editor")
is likely representing the state of the configuration file.Here I changed our logic to read from
vscode.window.activeTextEditor.options
always because we can't make sure we are the only one that modifies it. People might install other extensions that modify the options at runtime as well.vscode.window.activeTextEditor.options
is our best choice now.BTW, I'll raise the issue to @code team about the configuration sync issue because we are adding API support for other configuration part.