Fix spec for otherModesKeyBindings to match insert #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
According to the readme, and looking at the implementation, these should take a similar config object.
|
Note: This is my first time editing a VSCode plugin and I don't think I have my node environment set up properly so I haven't actually tested this, but looking at the code the "other" and "insert" shares the same class with only a different config key. |
|
Ok, I've tested this now, and set up remaps using the array syntax in the development plugin environment. |
|
I have no idea what to do about the test failures. They seem unrelated to this change. |
|
Thanks for the PR, @sectioneight! Apologies for the broken tests; we're working on it... 😅 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No existing issue that I can find, happy to open one if that helps.