Fix TS2318 and ignore .vscode-test folder #400
Conversation
|
👍 , though you can actually just delete vscode-test entirely and test within VSCode itself. |
| "node_modules", | ||
| ".vscode-test" | ||
| ], | ||
| "files": [ |
There was a problem hiding this comment.
I was looking into this a bit earlier, doesn't the files config define what files tsc will compile? (ref: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html).
If no "files" property is present in a tsconfig.json, the compiler defaults to including all TypeScript (*.ts or *.tsx) files in the containing directory and subdirectories. When a "files" property is present, only the specified files are included.
Edit: Reading the documentation and SO posts, I'm so confused on what this attribute is.
There was a problem hiding this comment.
I was referring to microsoft/TypeScript#3930 , seems if you set nolib as true you must add your own lib file as TypeScript compiler always rely on lib files to generate output. So the main purpose of nolib is allowing you to replace the original lib.d.ts to the one you want, here it's lib.es6.d.ts.
I'm not 100% sure whether it's correct but currently it's the only way to bypass the errors.
There was a problem hiding this comment.
@jpoon you were correct; unfortunately, this change will break typescript compilation.
Be sure to test tsc --watch before making changes to tsconfig.json 😉
|
@johnfn the reason I always test those cases with command line is it's the same way as Travis does. Currently if you run tests inside VS Code, everything is good while if you run through command line, it will fail immediately. I mentioned this issue in Slack and it's due to HistoryTracker initialization. |
|
The Travis thing is annoying, but it's not really indicative of how real people will use our extension. I put more weight on running the tests within VSCode because those results seem to correlate stronger with actual bugs existing in the code. |
|
@jpoon @johnfn sorry for the break and thanks for @johnfn 's quick turnaround. The only thing that bothers me is, why we put I can ignore these things as it doesn't affect the functionality but the catch is, VS Code is relying on the lib file to do intellisense and since the lib file is missing, we are seeing hundreds of errors highlighting in editor, which makes the whole development hard. Maybe I did something wrong with my local setup, any comments? |
|
@rebornix My mistake. You're right about TS2318. We have some files in our typings/ directory that have been gitignore'd from an old version (including lib.es6). You don't have those files. So we don't see TS2318, but you do. HOWEVER, we can't just add lib.es6 to the files array, because that unadds all of the files in src/, which breaks The correct solution for now is to just add back lib.es6 to the typings directory. When Typescript 2 rolls around, we can use glob stars in the files array, so we can do "src/**' |
Yay! We love PRs! 🎊
Please include a description of your change & check your PR against this list, thanks:
gulp tslint)Firstly ignore
.vscode-testfolder, otherwise it will slow down the auto-compilation. Secondly as we setnoLibastrueand we are using ES6 most of the time (currently we don't have any ES7 syntax yet), so I add es6 lib file to it.