Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbench.files.action.closeAllFiles is deprecated. #395

Merged
merged 1 commit into from
Jul 6, 2016

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Jul 5, 2016

Yay! We love PRs! 🎊

Please include a description of your change & check your PR against this list, thanks:

  • Commit message has a short title & issue references
  • Commits are squashed
  • It builds and tests pass (e.g gulp tslint)

workbench.files.action.closeAllFiles is deprecated and we should use workbench.action.closeAllEditors instead, which is already invoked before.

This is just test code so it won't block any user as we are using the latest version of VS Code to develop. But if it's an API we are using in production code, I don't know how we can avoid breaking users using old version of VS Code.

@johnfn johnfn merged commit 0fe9530 into VSCodeVim:master Jul 6, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants