Add Ncc support and revise cc behavior #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ import { VimState } from './../mode/modeHandler'; | |||
| * There are two different modes of copy/paste in Vim - copy by character | |||
| * and copy by line. Copy by line typically happens in Visual Line mode, but | |||
| * also shows up in some other actions that work over lines (most noteably dd, | |||
| * yy, and cc). | |||
|
Good stuff. This has been bugging me for a while. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original
ccbehaviour is not the same as Vim. When you triggerccin Vim with below content,You will get
However, what we get in VSCodeVim is
I suppose it's not a correct way of
ccand it's caused by treatingccasLineWise. Now I add numeric support and set it asCharacterWiseto fix this problem.