Support << and >>
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| console.log(keys); | ||
| if (this.keyHandler[key] !== undefined) { | ||
| // Bug: 'two characters does not work' |
There was a problem hiding this comment.
There's a bug right now where for some reason, I can't build a key with more than one chars.
jpoon
force-pushed
the
indent_commands
branch
from
d1f4d80
to
f668fb8
Compare
jpoon
force-pushed
the
indent_commands
branch
3 times, most recently
from
0afa535
to
80da17a
Compare
| case 'l': | ||
| vscode.commands.executeCommand("cursorRight"); | ||
| var keyHandled = false; | ||
| for (var window = 0; window <= this.keyHistory.length; window++) { |
There was a problem hiding this comment.
Use let here because that's the intent?
There was a problem hiding this comment.
Yeah, habit. Should be adopting let.
jpoon
force-pushed
the
indent_commands
branch
from
80da17a
to
2c272ac
Compare
jpoon
force-pushed
the
indent_commands
branch
from
2c272ac
to
f0f626a
Compare
jpoon
force-pushed
the
indent_commands
branch
from
fb9635e
to
4e190a6
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR that adds support for
>>and<<.