Use vscode built in support for block cursors #245
Conversation
|
@Paxxi sweet! there's a minor tslint error that's making the build fail
|
|
Ahh right, forgot to run tslint, will fix tomorrow |
|
Fixed the tslint error and rewrote it a bit to make it a bit shorter |
|
|
||
| modeHandler.setCurrentModeByName(ModeName.Insert); | ||
| assert.equal(vscode.window.activeTextEditor.options.cursorStyle, vscode.TextEditorCursorStyle.Line); | ||
| }); |
There was a problem hiding this comment.
Can you add another case here for Visual mode?
|
Ok added the test case. Note for the future, I can be sloppy sometimes in PR's so don't hesitate to "nitpick", I expect it 😄 |
|
@Paxxi one more tiny thing, can you merge the latest changes from |
|
done |
|
@Paxxi unfortunately this makes visual line mode confusing :( In visual line mode, the block cursor is often in the middle of the linewise selection (Vim will always select the entire line the cursor is in, no matter if it's at the beginning or the end). Can you find any way to fix this? Otherwise we'll have to revert, which would be a shame because this cursor is really nice. |
|
I see the issue, will investigate and see how we can solve it |
|
Not sure if I will have time to investigate in the next few days so maybe revert this in case you want to do a release and we can give it another try once I figure it out |
Added some simple tests for this and moved it out of the hot path as it's something that only happens during mode changes.