Possibility to set statusBar foreground color #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis tests have failedHey Mikael Göransson, Node.js: 8.9.1git ls-tree -r HEAD --name-only | grep ".*.[t|j]s$" | xargs ./node_modules/prettier/bin/prettier.js --write --print-width 100 --single-quote --trailing-comma es5gulp |
jpoon
requested changes
Jan 31, 2018
| @@ -31,15 +31,22 @@ class StatusBarClass implements vscode.Disposable { | |||
| } | |||
| } | |||
|
|
|||
| public SetColor(color: string) { | |||
| public SetColor(background: string, foreground?: string) { | |||
| const currentColorCustomizations = vscode.workspace | |||
There was a problem hiding this comment.
Can you call Configuration.getConfiguration here?
There was a problem hiding this comment.
You mean instead of calling vscode.workspace.getConfiguration('workbench').get('colorCustomizations') I should use something like Configuration.getConfiguration('workspace').get('colorCustomizations')? (not able to look up the exact syntax right now :)). If so, then it should be used when updating the configuration as well?
There was a problem hiding this comment.
Actually scratch that, I realize this fx is not exposed in IConfiguration.
src/statusBar.ts
Outdated
| }; | ||
| if (foreground !== undefined) { | ||
| newColorCustomizations['statusBar.foreground'] = `${foreground}`; | ||
| } else if (currentColorCustomizations !== undefined && 'statusBar.foreground' in currentColorCustomizations) { |
There was a problem hiding this comment.
Should be sufficient to only have an else, and run delete currentColorCustomizations['statusBar.foreground']; if foreground is undefined.
There was a problem hiding this comment.
That would result in [ts] Object is possibly 'undefined'.
There was a problem hiding this comment.
Actually, I realized that the delete will modify the object, but won't actually update it with VSCode.
This should be better:
public SetColor(background: string, foreground?: string) {
const currentColorCustomizations = vscode.workspace
.getConfiguration('workbench')
.get('colorCustomizations');
let colorCustomizations = Object.assign(currentColorCustomizations, {
'statusBar.background': `${background}`,
'statusBar.noFolderBackground': `${background}`,
'statusBar.debuggingBackground': `${background}`,
});
if (foreground === undefined) {
delete colorCustomizations['statusBar.foreground'];
} else {
colorCustomizations['statusBar.foreground'] = `${foreground}`;
}
vscode.workspace
.getConfiguration('workbench')
.update('colorCustomizations', colorCustomizations, true);
}
jpoon
reviewed
Jan 31, 2018
|
Sorry for late response, I have had a hectic week. I'll fix it during the weekend, when my additional questions has been cleared out. |
mgor
force-pushed
the
statusbar-foreground
branch
2 times, most recently
from
479bdb6
to
5c8b17c
Compare
Basically a reimplementation of pull#2102. Updated documentation to include instructions on how colors are set.
mgor
force-pushed
the
statusbar-foreground
branch
from
5c8b17c
to
aa8deb3
Compare
jpoon
approved these changes
Feb 5, 2018
|
Sorry for taking so long to merge this in. Still on vacation. I'll merge as soon as this new build passes CI. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Basically a reimplementation of #2102. Updated documentation to include instructions on how colors are set.
Having the possibility to set the foreground color makes it easier to select a background color and get a good contrast between the two.
Which issue(s) this PR fixes
N/A.
Special notes for your reviewer:
N/A.