Default to vim behaviour for Ctrl+D #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users installing a vim plugin will probably expect Ctrl+D to work like vim. This overrides the default behaviour in VS Code where Ctrl+D is a shortcut to "Add Selection to Next Find Match".
|
@jpoon Thank you for your hard work 👍 Could you trigger a release? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Users installing a vim plugin will probably expect Ctrl+D to work like
vim. So this changes the default settings to do that.
Which issue(s) this PR fixes
Fixes #2312
Special notes for your reviewer:
I tried adding tests, but then realized that Ctrl+D / Cmd+D doesn't actually work as per #1348 and I've been using the workaround posted there.