Rewrite Normal Mode tests to use the ModeHandler interface. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnfn
force-pushed
the
rewrite-some-tests
branch
from
9e507fc
to
4601645
Compare
johnfn
force-pushed
the
rewrite-some-tests
branch
from
38bb950
to
fc0acf1
Compare
|
Woot, looks like I fixed the tests intermittently failing, as well! 😀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is much nicer because now it's an end-to-end test of the Vim interface. Also, it's much easier to test that commands allow us to enter/leave different modes.