Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: status bar not updating following toggle #2283

Merged
merged 1 commit into from
Jan 12, 2018
Merged

fix: status bar not updating following toggle #2283

merged 1 commit into from
Jan 12, 2018

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Jan 12, 2018 •
edited
Loading

What this PR does / why we need it:

  • fixes status bar not updating correctly following disabling of vim (through toggleVim).
  • instead of ad-hoc handling toggleVim, creating a new DisabledMode which aligns with our architecture
  • reorganize modes.ts to same order as mode enum.

Which issue(s) this PR fixes

Special notes for your reviewer:

@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Jan 12, 2018
@jpoon jpoon merged commit b1a8bbb into master Jan 12, 2018
@jpoon jpoon deleted the disable-vim branch January 12, 2018 10:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpoon