Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: normalize keys when loading configuration #2268

Merged
merged 5 commits into from
Jan 6, 2018

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Jan 5, 2018

What this PR does / why we need it:

  • move logic out of modeHandler into configuration simplifying modeHandler, and simplifying accessing keybindings/remappedKeys settings as the keys will already be normalized to angle bracket notation.
  • update status bar text to be more like vanilla vim

Which issue(s) this PR fixes

Special notes for your reviewer:

@jpoon jpoon merged commit 8416cfb into master Jan 6, 2018
@jpoon jpoon deleted the refactor-configuration branch January 6, 2018 00:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant