Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Silently Failing #2250

Merged
merged 7 commits into from
Jan 4, 2018
Merged

Stop Silently Failing #2250

merged 7 commits into from
Jan 4, 2018

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Dec 28, 2017

Fixes:

  • Stop silently failing. Either display error to user or throw back to vscode to handle.
  • Update npm packages
  • Fix deleting matching braces on overlapped transformations
  • Fix gulp patch|minor|major commands. Only create a git tag once.

Refactor:

  • Moving logic away from modehandler -- moving vimstate dispose to vimstate, using anonymous function for text transformation instead of having the code twice.

@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Jan 2, 2018
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Jan 2, 2018
…n removing dupe code, move friendly name to mode class
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Jan 2, 2018
@jpoon jpoon changed the title Error handling Stop Silently Failing Jan 3, 2018
@jpoon jpoon merged commit 1a6a784 into master Jan 4, 2018
@jpoon jpoon deleted the error-handling branch January 4, 2018 01:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant