Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc Bug Fixes and Refactoring #2243

Merged
merged 20 commits into from
Dec 28, 2017
Merged

Misc Bug Fixes and Refactoring #2243

merged 20 commits into from
Dec 28, 2017

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Dec 24, 2017 •
edited
Loading

Bug Fixes:

  • history-tracker: handle when editor is null
  • fix bug where search decorator would reset following initial search
  • show save details :w in status bar
  • remove generator-changelog scripts. we'll stop using GH releases and generate using npm-generate-changelog
  • Text width ignored when wrapping #2247. displays error on cmd_line errors instead of silently failing.

Refactor:

  • moving logic away from modeHandler into separate classes (e.g. remappers, statusbar)
  • less spaghetti code with vim state removing dependency on modeHandler

@jpoon jpoon force-pushed the misc branch 2 times, most recently from ae93a11 to 1d98df9 Compare December 24, 2017 11:25
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Dec 24, 2017
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Dec 24, 2017
@jpoon jpoon force-pushed the misc branch 2 times, most recently from 5b4b40a to 0c661e3 Compare December 24, 2017 12:19
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Dec 24, 2017
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Dec 24, 2017
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Dec 24, 2017
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Dec 24, 2017
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Dec 25, 2017
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Dec 25, 2017
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Dec 25, 2017
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Dec 25, 2017
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Dec 25, 2017
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Dec 25, 2017
@jpoon jpoon force-pushed the misc branch 2 times, most recently from 0c82a10 to 259df0e Compare December 25, 2017 12:27
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Dec 25, 2017
@VSCodeVim VSCodeVim deleted a comment from TravisBuddy Dec 25, 2017
@jpoon jpoon changed the title Refactor Misc Bug Fixes and Refactoring Dec 27, 2017
@jpoon
Copy link
Member Author

jpoon commented Dec 27, 2017

Any review comments before I merge?

@jpoon jpoon merged commit 82abec3 into master Dec 28, 2017
@jpoon jpoon deleted the misc branch December 28, 2017 11:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpoon