Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2155, Fix #2133: escape delimiter substitute #2159

Merged
merged 2 commits into from
Nov 18, 2017

Conversation

westim
Copy link
Contributor

@westim westim commented Nov 18, 2017

This PR addresses the issue where the slash / character could not be substituted using standard Vim syntax. I have added tests for the substitute and subparser substitute to cover this functionality.

This change ensures that, if a substitution pattern contains an attempt
to escape the delimiter '\/', the delimiter is correctly added to the
pattern.
Copy link
Member

@jpoon jpoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jpoon jpoon merged commit 0dec4c2 into VSCodeVim:master Nov 18, 2017
@westim westim deleted the escape-substitute branch November 18, 2017 15:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants