Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ^, $, add case sensitivity override in search #2123

Merged
merged 3 commits into from
Nov 9, 2017

Conversation

parkovski
Copy link
Contributor

Substitute is not affected by either of these issues - ^ and $ already work there, and /i to override case is already implemented - vim doesn't support \c there.

…deVim#2101, VSCodeVim#2100

Without the 'm' flag, '^' and '$' match the beginning and end of the
file. Adding this flag matches Vim's behavior. This also implements
vim's '\c' and '\C' flag to override ignorecase settings for the current search.
@jpoon
Copy link
Member

jpoon commented Nov 9, 2017

LGTM. Fix the build error and then we can merge.

Compile with gulp first (to format things properly with prettier) before pushing!"; sleep 1; exit 1; }; else echo "Prettier passed."; fi

@jpoon jpoon self-requested a review November 9, 2017 04:51
@parkovski
Copy link
Contributor Author

parkovski commented Nov 9, 2017

When I run gulp locally nothing changes - it's giving the same error for all the recent PRs for changes none of them made.

@parkovski
Copy link
Contributor Author

I see what's wrong, I had an older version of prettier than travis. Should I add the fixed files to this PR, and if so should I update package.json? Since the version of prettier listed may not work.

@jpoon jpoon merged commit 1de9900 into VSCodeVim:master Nov 9, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants