keep workbench color customizations when using status bar color

[twin-tigon]

When the status bar color is controlled by the current mode, the workbench color customizations get overwritten by the status bar customizations, removing any previous existing customization. This change merges both existing and status bar customizations to avoid this behavior.

[jpoon]

I believe this fixes #1654 and #2150

[jpoon]

Consider separating the get and the update into two separate lines for readability.

[jpoon]

With this change, it also means that if you have workbench configuration, the statusBar settings are ignored.

As the colorCustomizations lives at the workspace level (https://code.visualstudio.com/docs/getstarted/theme-color-reference), this seems like the only alternative.

Soliciting @zelphir and @thousand opinions as they both filed related issues (#2150, #1654). Would this fix satisfy your ask?

[thousand]

@jpoon looks good to me! I would expect that the plugin's behavior could overwrite or replace the behavior of the related configs.

[jpoon]

I've never used Object.assign before, is there a difference between:

1. Object.assign({}, currentColor....) and
2. Object.assign(currentColor...,

ie. why do you need the initial {}?

[twin-tigon]

The first parameter of the Object.assign function is the target object. Like you wrote below, it works like an upsert, where from left to right properties get merged.

This is the behavior that I intend, since I want to get a copy of the color customizations and then overwrite its properties regarding the status bar.

The target object gets modified by the Object.assign call, that's why I pass an empty object at first. But indeed, in this case, this is not needed. I will remove it.

[jpoon]

Actually, I misinterpreted the behaviour of object.assign, I thought it would only set the value if the key is null (like null coalescing), but it's more of an upsert.

That being said, that means we'll be overwriting some settings at the workbench level. I'm OK with this change, but want to double-check with your opinions @thousand @rodrigo-garcia-leon @zelphir on that's what you guys expect.

[jpoon]

Thanks @rodrigo-garcia-leon

[twin-tigon]

No problem! 😄