Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1945 $ in VisualBlock works on ragged lines #2096

Merged
merged 5 commits into from
Dec 4, 2017
Merged

Fix #1945 $ in VisualBlock works on ragged lines #2096

merged 5 commits into from
Dec 4, 2017

Conversation

Strafos
Copy link
Contributor

@Strafos Strafos commented Oct 26, 2017

Change end position so if $ key is pressed in VisualBlock, each line will go to end of line.

@xconverge
Copy link
Member

@jpoon is the package-lock supposed to change often or should it not be part of most PRs?

@jpoon
Copy link
Member

jpoon commented Oct 31, 2017 •
edited
Loading

@xconverge sorry, missed this notification. Where did our package-lock.json go? Aside from that, this PR looks good to me.

@jpoon
Copy link
Member

jpoon commented Oct 31, 2017 •
edited
Loading

Fixes #1945. @Strafos, mind removing package-lock.json from this change? Thanks.

@jpoon jpoon merged commit d76d268 into VSCodeVim:master Dec 4, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Strafos @xconverge @jpoon