Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for copy and p command #208

Merged
merged 7 commits into from
May 3, 2016
Merged

Support for copy and p command #208

merged 7 commits into from
May 3, 2016

Conversation

petegleeson
Copy link

Hello, I have added two things:

  1. Support for copying to the system clipboard
  2. A basic version of the put command that pastes from the system clipboard

When first looking around I found this issue on the vscode repository about supporting copy/paste operations for extensions. I have followed the advice in that issue and included the copy-paste npm package to do copy/paste.

Be great to hear what everyone thinks 👍

edthedev added a commit to edthedev/Vim that referenced this pull request Apr 26, 2016
I think this may fix the build failures connected to VSCodeVim#208
@petegleeson
Copy link
Author

The build stage seems to be fixed but there is still a problem with some of the unit tests falling over. The error /bin/sh: 1: xclip: not found indicates that the linux copy command isn't there. Could be that the docker image doesn't have this installed. Can we apt-get install xclip in the dockerfile? Smells problematic if linux doesn't come with xclip installed by default.

@edthedev
Copy link
Contributor

edthedev commented Apr 30, 2016

I was able to craft an update to the Travis CI config that fixes the problem.
https://travis-ci.org/edthedev/Vim/builds/126945589

Here is the commit.
edthedev@4fe2ec8

@jpoon
Copy link
Member

jpoon commented May 2, 2016

@petegleeson , is there a way in which you can merge @edthedev change (#211) into your own PR?

@edthedev
Copy link
Contributor

edthedev commented May 3, 2016

My initial fork was from this branch, so unless I'm mistaken, @petegleeson's commits are included.

I intended to make my pull request back to his copy for #209, but I could not figure out how. I think I pressed the fork button one too many times in the GitHub web interface.

@edthedev
Copy link
Contributor

edthedev commented May 3, 2016

I'll be happy to submit a corrected pull if someone can direct me how. Couldn't find the thing when U tried, but it was kind late. I might have missed something obvious.

@edthedev
Copy link
Contributor

edthedev commented May 3, 2016

Huh. @peteglessons commits are not part of #211. I think I can merge, then submit a new pull.

@edthedev
Copy link
Contributor

edthedev commented May 3, 2016

I did some comparison and found that @petegleeson's solution to the travis.yml file was superior to mine anyway. I have closed #211 as it adds nothing that is not already here.

@edthedev
Copy link
Contributor

edthedev commented May 3, 2016

Latest commit on this branch passes in Travis for me.
https://travis-ci.org/edthedev/Vim/builds/127404327

@petegleeson
Copy link
Author

Well the travis builds has gone green without any code changes... @edthedev with the magic touch. If you guys are happy with these changes I would love to get this merged 😄

@edthedev
Copy link
Contributor

edthedev commented May 3, 2016

Looks good.

I closed #212 as duplicate. I'm not sure if Travis CI getting happy is related to poking it again, or if the timing is just coincidence.

Either way, I'm glad that Travis CI agrees that this looks good to go, though. :)

@jpoon jpoon merged commit 7655907 into VSCodeVim:master May 3, 2016
@jpoon
Copy link
Member

jpoon commented May 3, 2016

@petegleeson, @edthedev: Thanks guys. Also pushed out a new release.

@jpoon jpoon mentioned this pull request May 4, 2016
@jpoon
Copy link
Member

jpoon commented May 4, 2016

Weird, the master branch builds are now broken :|

@edthedev
Copy link
Contributor

edthedev commented May 4, 2016

Changing sudo: false to sudo: true in .travis.yml will probably did the problem. I'm guessing Travis CI changes their rules based on usage frequency thus the tests fail on the main repo after passing in the micro forks.

@edthedev
Copy link
Contributor

edthedev commented May 4, 2016

I would fork and test my theory, except that I will probably continue to get a passing build in my fork, anyway.

If I can find anything in the Travis docs that could shed done light, I'll report that info back here.

@jpoon jpoon mentioned this pull request May 4, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants