Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade packages #2070

Merged
merged 2 commits into from
Oct 13, 2017
Merged

Upgrade packages #2070

merged 2 commits into from
Oct 13, 2017

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Oct 13, 2017 •
edited
Loading

  • Upgrade npm packages. Add package-lock.json file
  • Fix lint issues
  • Clean-up unused build tasks
  • Refactor task queue, it was bugging me

@xconverge
Copy link
Member

Might want to add package-lock.json to the .gitignore?

@jpoon
Copy link
Member Author

jpoon commented Oct 13, 2017

I am intending to commit package-lock.json (ie. I don't want it in the gitignore).

@xconverge
Copy link
Member

Got it, just read up on https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all/

@xconverge
Copy link
Member

LGTM

@jpoon jpoon merged commit 11be4a4 into master Oct 13, 2017
@jpoon jpoon deleted the upgrade_packages branch October 13, 2017 22:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpoon @xconverge