Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #1951: text selection in insert mode #2062

Merged
merged 2 commits into from
Oct 11, 2017

Conversation

DanEEStar
Copy link
Contributor

Use the normal selection in insert mode.
This fixes #1951. Selection in insert mode seems to be
specific to this plugin and is not easily possible in normal Vim.

Use the normal selection in insert mode.
This fixes VSCodeVim#1951. Selection in insert mode seems to be
specific to this plugin and is not easily possible in normal Vim.
@xconverge
Copy link
Member

Did you compile with gulp? It should run prettier on your code to fix up whitespace and conform...

@DanEEStar
Copy link
Contributor Author

I did run with gulp compile.

It did not change any files on my machine. Do you have an idea what I did wrong?

@DanEEStar
Copy link
Contributor Author

I did run the command from the travis-ci manually:

git ls-tree -r HEAD --name-only | grep ".*.[t|j]s$" | xargs ./node_modules/prettier/bin/prettier.js --write --print-width 100 --single-quote --trailing-comma es5

This did fix some whitespace issues. See next commit.
But it did not fixup my files when running gulp compile before...

@xconverge
Copy link
Member

This looks like a nice change and we do less wonky stuff with selection! Thanks!

@xconverge xconverge merged commit c11bf8f into VSCodeVim:master Oct 11, 2017
DanEEStar added a commit to DanEEStar/Vim that referenced this pull request Oct 11, 2017
xconverge added a commit that referenced this pull request Oct 11, 2017
…-code

removed code which is not needed anymore due to #2062
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting text backwards in insert mode only selects first character
2 participants