Fixes #1248: support for '., `., and gi commands. #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westim
changed the title
|
Can you update the roadmap as well please thanks https://github.com/VSCodeVim/Vim/blob/master/ROADMAP.md |
xconverge
reviewed
Sep 27, 2017
src/history/historyTracker.ts
Outdated
| if (this.currentHistoryStepIndex === 0) { | ||
| return undefined; | ||
| } | ||
| let lastChangeIndex = this.historySteps[this.currentHistoryStepIndex].changes.length; |
There was a problem hiding this comment.
can we use const instead of let here
|
thanks, LGTM, just one small comment! |
westim
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to resolve issue #1248.
I'm not sure whether the
historyTrackerclass can be properly unit-tested, as I couldn't find any related tests. If it's possible, I'd love to get some suggestions & backfill those tests.