Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #1860, visual multicursor movement. #2036

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

westim
Copy link
Contributor

@westim westim commented Sep 21, 2017

This is a cleaner Pull request for fixing this issue, replacing closed Pull request #2029. Please reference the comments & details in issue #1860 for info, including the problem definition & solution justification.

@nguymin4 - Per your comments on #2029, I have implemented this fix using Array.map().

@xconverge
Copy link
Member

I am hesitant to merge this without doing a quick sanity check as well, please don't take the radio silence as ignoring you! I have just been a bit busy

I will try to check this out tonight but I am OK merging it

@xconverge
Copy link
Member

Did a quick sanity check and your investigation was very thorough!

Merging this, thanks a lot!

We will keep an eye out for new issues being reported when we do the next release, but should be good to go!

@xconverge
Copy link
Member

FYI your wording was close on the PR to have it do something handy

https://help.github.com/articles/closing-issues-using-keywords/

If your pr says fixes #xxxx then it will auto close the issue when the PR is merged!

@westim
Copy link
Contributor Author

westim commented Sep 27, 2017

Ok, thanks for the heads-up! I just changed the title for the other open PR to hopefully utilize that Github feature.

@westim westim deleted the visual-multicursor branch October 11, 2017 13:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants