Fixes Incorrect Cursor Position after Transition into Normal Mode #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! Re-ran the tests. Not sure why the failed -- will need to look into that. Do you mind resolving the conflicts? As soon as that happens, I can merge this. |
- By having `redraw` enforce cursor position, we were double moving becase both `redraw` (via `Motion.changedMode`) and `handleActivationKey` were moving the cursor left. This makes it so `redraw` is not responsible for enforcing the cursor position. Instead, position enforcement is handled only when the cursor may have been moved externally (ie via the mouse).
dpbackes
force-pushed
the
NormalModeTransition
branch
from
64aa10f
to
06d0975
Compare
|
My pleasure! Conflicts resolved. |
|
Looks great, let me restart these builds just to make sure :) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redrawenforce cursor position, we were doublemoving because both
redraw(viaMotion.changedMode) andhandleActivationKeywere moving the cursor left. This makesit so
redrawis not responsible for enforcing the cursorposition. Instead, position enforcement is handled only when
the cursor may have been moved externally (ie via the mouse).
Closes #201