Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easymotion improvements #2017

Merged
merged 12 commits into from
Sep 16, 2017
Merged

Conversation

maxfie1d
Copy link
Contributor

@maxfie1d maxfie1d commented Sep 13, 2017

Make easymotion work even better.

Improvements

Fixes

  • Fix EASYMOTION MODE text is not rendered on the status bar after switching texteditors

@maxfie1d maxfie1d changed the title [WIP] Easymotion improvements Easymotion improvements Sep 15, 2017
@maxfie1d
Copy link
Contributor Author

maxfie1d commented Sep 15, 2017

I don't know what vscode theme color is good for markers' background and foreground.
For now, I used activityBarBadge.background and activityBarBadge.foreground.

https://github.com/MaxfieldWalker/Vim/blob/abffbce06dc2f2a16cbfdcaccf1f63f3ff612145/src/actions/plugins/easymotion/easymotion.ts#L213-L229

Examples

Spirited Away Theme

image

Solarized Dark Theme

image

All available colors are found here.

@Chillee
Copy link
Member

Chillee commented Sep 15, 2017

Nice! That looks awesome (way better than our current default of red and black...). However, it seems like you've gotten rid of the current method of choosing colors. Would it be possible to only use the background color if the user has not manually chosen his own colors? I am worried that it does limit customizability for those that want it.

We're also having some trouble with Travis. I'll take a look tonight.

@maxfie1d
Copy link
Contributor Author

maxfie1d commented Sep 15, 2017

This is the function to select color.

https://github.com/MaxfieldWalker/Vim/blob/abffbce06dc2f2a16cbfdcaccf1f63f3ff612145/src/actions/plugins/easymotion/easymotion.ts#L193-L207

vim.easymotionMarkerBackgroundColor, vim.easymotionMarkerForegroundColorOneChar, vim.easymotionMarkerForegroundColorTwoChar options are still alive.

This is a customize example with the configuration below.

{
    "vim.easymotionMarkerForegroundColorOneChar": "#000",
    "vim.easymotionMarkerForegroundColorTwoChar": "#000"
}

image

@Chillee
Copy link
Member

Chillee commented Sep 16, 2017

@MaxfieldWalker Awesome. So it only uses the theme's settings if those settings aren't manually set?

@maxfie1d
Copy link
Contributor Author

@Chillee Yes, exactly.

@Chillee
Copy link
Member

Chillee commented Sep 16, 2017

Great! I've fixed the Travis issues, so I'll merge this (and some other PR's) and then issue a release tonight!

@Chillee
Copy link
Member

Chillee commented Sep 16, 2017

@MaxfieldWalker Actually, it seems like an easymotion test is failing, so can you check that?

@Chillee Chillee merged commit a367d12 into VSCodeVim:master Sep 16, 2017
@maxfie1d maxfie1d deleted the easymotion-improvements branch September 16, 2017 03:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants