Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ex mode #20

Merged
merged 1 commit into from
Nov 19, 2015
Merged

Ex mode #20

merged 1 commit into from
Nov 19, 2015

Conversation

guillermooo
Copy link
Member

@jpoon I think this can be merged.

@jpoon
Copy link
Member

jpoon commented Nov 19, 2015

Nice! One thing, squash commits please :)

@guillermooo
Copy link
Member Author

@jpoon When you say squash, you mean just one commit per PR? Sometimes I find it clearer to have separate commits if they are unrelated (not that I'm very disciplined with this, though). For example, above we have commits that change whitespace only. To me, it makes sense to keep those separate. But I'm just trying to figure out the style we have to follow. I'm ok either way.

@jpoon
Copy link
Member

jpoon commented Nov 19, 2015

I'd like to keep master branch as clean as possible. People (maybe just me) don't really care about how the sausage is made -- they just want the sausage. I don't need to see the various commits that were made to get a feature or bug fixed, I just want to know that this one particular commit did it all. That means squashing commits down to a few, or one, discreet commit. In turn, this will make it easier to navigate through the commit history.

http://programmers.stackexchange.com/questions/263164/why-squash-git-commits-for-pull-requests

guillermooo added a commit that referenced this pull request Nov 19, 2015
@guillermooo guillermooo merged commit 396006b into master Nov 19, 2015
@jpoon jpoon deleted the ex-mode branch November 19, 2015 22:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants