Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement '' and ``. #1993

Merged
merged 3 commits into from
Sep 16, 2017
Merged

Implement '' and ``. #1993

merged 3 commits into from
Sep 16, 2017

Conversation

brandonbloom
Copy link
Contributor

Fixes #1089.

Dependency: microsoft/vscode#33715

@brandonbloom
Copy link
Contributor Author

This is currently untested, pending acceptance of upstream patch.

@Chillee
Copy link
Member

Chillee commented Sep 2, 2017

@brandonbloom Sorry, what's the difference between <C-o> and the actions you've implemented?

@brandonbloom
Copy link
Contributor Author

The difference is what happens f you execute the command twice in a row. Instead of going back, then back again, it goes back, then forward, alternating back and forth. Very useful for comparing things at distinct points the same file quickly: just hit tick or single-quote over and over again to flip back and forth.

This was referenced Sep 4, 2017
Merged
Closed
@xconverge
Copy link
Member

Nice job on the two repo attack here! It is pretty cool when your change gets merged into vscode and here and then the next release makes you happier :)

@Chillee
Copy link
Member

Chillee commented Sep 7, 2017

@brandonbloom Awesome! Nice job! Could you add some tests for this feature?

@brandonbloom
Copy link
Contributor Author

Are there any tests for CommandNavigateBack?

@Chillee
Copy link
Member

Chillee commented Sep 11, 2017

Actually, I doubt we need tests for this; it's just a wrapper of the corresponding VSCode command.

@Chillee Chillee merged commit 7fb538f into VSCodeVim:master Sep 16, 2017
@Chillee
Copy link
Member

Chillee commented Sep 20, 2017

Actually, this doesn't seem to work on the current release. I'm guessing it's an issue with the keybindings.

@brandonbloom
Copy link
Contributor Author

Check to see if the "Go Last" command is available in VS Code. My guess is not yet.

@westim westim mentioned this pull request Sep 22, 2017
Closed
@xconverge xconverge mentioned this pull request Oct 13, 2017
Closed
dsschnau added a commit to dsschnau/Vim that referenced this pull request Dec 4, 2018
@dsschnau
Re-implement `` and '' with jumpTracker
3f05973 
Closes VSCodeVim#3138.

`` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993.

This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to
surface.

In addition, the jumpTracker implementation requires jumps to be on
separate lines. As far as I can tell, this behavior is not neccesary.
This commit removes that requirement, instead requiring that different
jumps be only on separate positions.
dsschnau added a commit to dsschnau/Vim that referenced this pull request Dec 4, 2018
@dsschnau
Re-implement `` and '' with jumpTracker
07b4bf6 
Closes VSCodeVim#3138.

`` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993.

This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to
surface.

In addition, the jumpTracker implementation requires jumps to be on
separate lines. As far as I can tell, this behavior is not neccesary.
This commit removes that requirement, instead requiring that different
jumps be only on separate positions.
dsschnau added a commit to dsschnau/Vim that referenced this pull request Dec 4, 2018
@dsschnau
Re-implement `` and '' with jumpTracker
205c8e9 
Closes VSCodeVim#3138.

`` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993.

This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to
surface.

In addition, the jumpTracker implementation requires jumps to be on
separate lines. As far as I can tell, this behavior is not neccesary.
This commit removes that requirement, instead requiring that different
jumps be only on separate positions.
dsschnau added a commit to dsschnau/Vim that referenced this pull request Dec 4, 2018
@dsschnau
Re-implement `` and '' with jumpTracker
ce9dab2 
Closes VSCodeVim#3138.

`` and '' were implemented before the new jumpTracker in PR VSCodeVim#1993.

This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 to
surface.

In addition, the jumpTracker implementation requires jumps to be on
separate lines. As far as I can tell, this behavior is not neccesary.
This commit removes that requirement, instead requiring that different
jumps be only on separate positions.
@dsschnau dsschnau mentioned this pull request Dec 4, 2018
Merged
dsschnau added a commit to dsschnau/Vim that referenced this pull request Dec 6, 2018
@dsschnau
Re-implement and '' with jumpTrackerCloses VSCodeVim#3138. and '…
b23e952 
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
dsschnau added a commit to dsschnau/Vim that referenced this pull request Dec 6, 2018
@dsschnau
Re-implement and '' with jumpTrackerCloses VSCodeVim#3138. and '…
d6e3fe9 
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
dsschnau added a commit to dsschnau/Vim that referenced this pull request Dec 6, 2018
@dsschnau
Re-implement and '' with jumpTrackerCloses VSCodeVim#3138. and '…
9fbabc0 
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
dsschnau added a commit to dsschnau/Vim that referenced this pull request Dec 6, 2018
@dsschnau
Re-implement and '' with jumpTrackerCloses VSCodeVim#3138. and '…
4aa980d 
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
dsschnau added a commit to dsschnau/Vim that referenced this pull request Dec 6, 2018
@dsschnau
Re-implement and '' with jumpTrackerCloses VSCodeVim#3138. and '…
010036b 
…' were implemented before the new jumpTracker in PR VSCodeVim#1993.This caused these actions to fall out-of-sync, causing issue VSCodeVim#3138 tosurface.In addition, the jumpTracker implementation requires jumps to be onseparate lines. As far as I can tell, this behavior is not neccesary.This commit removes that requirement, instead requiring that differentjumps be only on separate positions.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avindra avindra avindra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandonbloom @Chillee @xconverge @avindra