Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make prettier work on Windows #1987

Merged
merged 3 commits into from
Sep 3, 2017
Merged

Make prettier work on Windows #1987

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e3aadb
make prettier work on Windows
maxfie1d Aug 29, 2017
8d431e8
Merge branch 'master' into win-prettier
Chillee Sep 2, 2017
dafc6ee
Merge branch 'master' into win-prettier
Chillee Sep 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ var gulp = require('gulp'),
tag_version = require('gulp-tag-version'),
tslint = require('gulp-tslint'),
typings = require('gulp-typings'),
shell = require('gulp-shell');
shell = require('gulp-shell'),
exec = require('child_process').exec;

var paths = {
src_ts: 'src/**/*.ts',
Expand Down Expand Up @@ -47,19 +48,29 @@ gulp.task('tslint', function() {
return merge(srcs, tests);
});

gulp.task(
'prettier',
shell.task([
'git diff --name-only HEAD | grep ".*.[t|j]s$" | xargs ./node_modules/prettier/bin/prettier.js --write --print-width 100 --single-quote --trailing-comma es5',
])
);
gulp.task('prettier', function() {
runPrettier('git diff --name-only HEAD');
});

gulp.task('forceprettier', function() {
// Enumerate files managed by git
runPrettier('git ls-files');
// Enumerate untracked files
runPrettier('git ls-files --others --exclude-standard');
});

gulp.task(
'forceprettier',
shell.task([
' find . | grep ".*\\.[t|j]s$" | xargs ./node_modules/prettier/bin/prettier.js --write --print-width 100 --single-quote --trailing-comma es5 ',
])
);
function runPrettier(command) {
exec(command, function(err, stdout, stderr) {
const files = stdout.split('\n');
for (const file of files) {
if (file.endsWith('.ts') || file.endsWith('.js')) {
exec(
`node ./node_modules/prettier/bin/prettier.js --write --print-width 100 --single-quote --trailing-comma es5 ${file}`
);
}
}
});
}

gulp.task('default', ['prettier', 'tslint', 'compile']);

Expand Down