Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1941: Action repetition with Ctrl-[ #1953

Merged
merged 7 commits into from
Aug 25, 2017
Merged

Fixes #1941: Action repetition with Ctrl-[ #1953

merged 7 commits into from
Aug 25, 2017

Conversation

tagniam
Copy link
Contributor

@tagniam tagniam commented Aug 5, 2017

Ctrl-[ is already defined as a synonym for Esc in CommandEsc. Removing CommandCtrlOpenBracket fixes the action repetition problem. I think it was code leftover from before a refactor.

Fixes #1941

@Chillee
Copy link
Member

Chillee commented Aug 8, 2017

@tagniam Thanks! I swear I'll fix the Travis issue soon(TM), and then I can merge a bunch of PR's :(

@Chillee
Copy link
Member

Chillee commented Aug 9, 2017

@tagniam Could you add a test covering this case?

Ask if you need any help with doing tests. newTestOnly allows you to just run one test when running the tests.

@tagniam
Copy link
Contributor Author

tagniam commented Aug 9, 2017

@Chillee Sure! I haven't written any tests with typescript before, is there anything you're looking for in particular?

@Chillee
Copy link
Member

Chillee commented Aug 9, 2017

@tagniam Just take a look at the other tests in the tests folder. I'd probably put it in modeNormal.test.ts

@Chillee
Copy link
Member

Chillee commented Aug 10, 2017

As for what the tests should cover, the test should break before you fixed this issue, and pass after you've fixed the issue.

So, for example,
you start with an empty file, input 5i=<C-[>, and end with =====.

@tagniam
Copy link
Contributor Author

tagniam commented Aug 10, 2017

@Chillee Thanks, I'm in the middle of exams right now but I'll get to writing the tests for both my PRs as soon as I can :)

@Chillee
Copy link
Member

Chillee commented Aug 10, 2017

@tagniam Good luck with your exams! I started working on VsCodeVim purely while I was procrastinating on exams :)

@tagniam
Copy link
Contributor Author

tagniam commented Aug 10, 2017

@Chillee Well it looks like I need to procrastinate more often then. :) Thanks!

@tagniam
Copy link
Contributor Author

tagniam commented Aug 14, 2017

@Chillee done!

@Chillee
Copy link
Member

Chillee commented Aug 25, 2017

Thanks for the contribution!

@Chillee Chillee merged commit 51a94d3 into VSCodeVim:master Aug 25, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No action repetition when leaving input mode with CTRL-[
2 participants