Makes all tests pass on Windows

[philipmat]

Fixes #1914

https://ci.appveyor.com/project/philipmat/vim/build/1.0.10

[jpoon]

1. Can you squash your commits?
2. I restarted Travis in hopes that it was a flukey error.

[Chillee]

@jpoon It has something to do with the neovim script I think. I've been busy interning (my evaluation period is coming up!) but somebody mentioned that it could have to do with our ubuntu version?

I think the better thing to do is to switch to the neovim appImage.

[philipmat]

@jpoon if you're asking me about squashing, I'd be happy to do it, but I believe GitHub already supports this through Squash and merge

[Chillee]

@philipmat Could you try resolving the conflict (which should be just removing test/cmd_line/read.test.ts) and running the tests again?

[Chillee]

Huh. I thought github could show you what the conflicts were.

[philipmat]

AppVeyor is green as well: https://ci.appveyor.com/project/philipmat/vim/build/1.0.13

[Chillee]

@philipmat Did you and @jpoon decide whether we want to re-integrate Appveyor checks?

[philipmat]

@jpoon said, and I quote:

Happy to set it up again [...]

:)

Y'all would need to add a badge, though.

[Chillee]

I always thought that it wasn't really necessary because it's electron, but I guess that's not really true, especially with neovim as well as all other sorts of things.

The main thing I'm concerned with Appveyor is tests being even more flaky, as well as increasing test times.

[philipmat]

The tests are not mandatory, but it's good to have signals that everything works well across all platforms VSCode runs on.

If you want to ignore a broken AppVeyor build, there's nothing stoppping you.

Oh, and AppVeyor seems to finish faster than Travis so there's no waiting either 😀

[Chillee]

So long as Windows test fail doesn't prevent us from pushing a release, that's good 👍

All we need now is to figure out what those conflicts are...

[philipmat]

They're not preventing you because you're using the Travis build to push a release (AFAICT)

I currently see no conflicts on this branch. Should I be looking elsewhere?

[Chillee]

No it's good now. Before it said that there were conflicts that needed to be resolved without showing any conflicts, so I was confused. Thanks.

[Chillee]

Huh. They seem to only show on web, but not on mobile.

http://i.imgur.com/vYUz67N.jpg

[Chillee]

I just merged it on mobile...