Commands can write to status bar #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should just remove it entirely or move the message to the status bar. |
|
We could move the message to the status bar. |
|
👍 |
frarees
force-pushed
the
save_message
branch
2 times, most recently
from
f3dca1a
to
52224e4
Compare
| @@ -81,12 +81,16 @@ export class ModeHandler implements vscode.Disposable { | |||
| } | |||
| } | |||
|
|
|||
| private setupStatusBarItem(text : string) : void { | |||
| private setupModeStatusBarItem(text : string) : void { | |||
There was a problem hiding this comment.
Can we consolidate these functions? setupModeStatusBarItem and setupStatusBarItem?
|
I've passed the mode handler down to the command. Will there be more than one instance of mode handler? Otherwise we could make it a singleton and that could simplify the API. |
|
Nah, this is fine. Thanks! |
jpoon
added a commit
that referenced
this pull request
Mar 10, 2016
Commands can write to status bar
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156.