Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for test files to get written #175

Merged
merged 1 commit into from
Mar 4, 2016
Merged

Wait for test files to get written #175

merged 1 commit into from
Mar 4, 2016

Conversation

frarees
Copy link
Contributor

@frarees frarees commented Mar 4, 2016

Waiting asynchronously for the workspace test files to get written helps to get rid of those unexpected cannot open file failures on test runs.

@frarees frarees mentioned this pull request Mar 4, 2016
Merged
@jpoon
Copy link
Member

jpoon commented Mar 4, 2016

Can we use writeFileSync (https://nodejs.org/api/fs.html#fs_fs_writefilesync_file_data_options)?

@frarees
Copy link
Contributor Author

frarees commented Mar 4, 2016

Yes. I tried to maintain the async API, but in this case there's not too much we can benefit from. I will push some changes here.

jpoon added a commit that referenced this pull request Mar 4, 2016
@jpoon
Merge pull request #175 from frarees/async_tests
2c31350 
Wait for test files to get written
@jpoon jpoon merged commit 2c31350 into VSCodeVim:master Mar 4, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frarees @jpoon