-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Fixes #754: Adds j,k,o,<Enter>, gg, G, ctrl+d, and ctrl+u commands for navigating inside the file explorer #1718
Conversation
I just wanted to note that these keybindings don't actually seem to work when I run it in debug mode. I'm not sure why. |
Oh, I just realized why we can't do this right now ( I think). |
Actually, I have no idea why this doesn't work. |
does it work? I dont think it does because of duplicate bindings |
No it doesn't. My internship's been sucking up a lot of my time so I've had less time to work on vscodevim :( |
The problem is we still think we have an active text editor I think, even when we are focused on the list |
@xconverge So the problem is this line (I think): https://github.com/VSCodeVim/Vim/blob/master/extension.ts#L355 It binds all of our commands to For now, we can just check the |
I also removed the duplicate keybindings test. I don't really think there's much benefit to it. |
I just copied @rebornix 's keybindings into package.json.
Fixes #754 and fixes #1351