Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Fixes #754: Adds j,k,o,<Enter>, gg, G, ctrl+d, and ctrl+u commands for navigating inside the file explorer #1718

Merged
merged 6 commits into from
Jun 22, 2017

Conversation

Chillee
Copy link
Member

@Chillee Chillee commented May 19, 2017

I just copied @rebornix 's keybindings into package.json.

Fixes #754 and fixes #1351

@Chillee
Copy link
Member Author

Chillee commented May 19, 2017

I just wanted to note that these keybindings don't actually seem to work when I run it in debug mode. I'm not sure why.

@Chillee
Copy link
Member Author

Chillee commented May 19, 2017

Oh, I just realized why we can't do this right now ( I think).

@Chillee Chillee closed this May 19, 2017
@Chillee Chillee reopened this May 19, 2017
@Chillee Chillee closed this May 19, 2017
@Chillee
Copy link
Member Author

Chillee commented May 19, 2017

Actually, I have no idea why this doesn't work.

@Chillee Chillee reopened this May 19, 2017
@Chillee Chillee changed the title Fixes #754: Navigating inside explorer list WIP Fixes #754: Navigating inside explorer list May 20, 2017
@xconverge
Copy link
Member

does it work? I dont think it does because of duplicate bindings

@Chillee
Copy link
Member Author

Chillee commented Jun 9, 2017

No it doesn't. My internship's been sucking up a lot of my time so I've had less time to work on vscodevim :(

@xconverge
Copy link
Member

The problem is we still think we have an active text editor I think, even when we are focused on the list

@Chillee
Copy link
Member Author

Chillee commented Jun 20, 2017

@xconverge So the problem is this line (I think): https://github.com/VSCodeVim/Vim/blob/master/extension.ts#L355
registerCommand(context, keybinding.command, () => handleKeyEvent(${ bracketedKey }));

It binds all of our commands to handleKeyEvent pretty much. I'm not really sure this is the right approach, but I'd need to think more about how to handle it better (if we even can).

For now, we can just check the keybinding.when to see whether we should be handling it.

@Chillee Chillee changed the title WIP Fixes #754: Navigating inside explorer list WIP Fixes #754: Adds j,k,o,<Enter>, gg, G, ctrl+d, and ctrl+u commands for navigating inside the file explorer Jun 20, 2017
@Chillee
Copy link
Member Author

Chillee commented Jun 21, 2017

I also removed the duplicate keybindings test. I don't really think there's much benefit to it.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert file with :e! Using j,k,l,i to navigate inside explorer list
2 participants