-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1534, #1518, #1716, #1618, #1450: Refactored repeating motions #1712
Conversation
I think this is another PR that's ready. Only controversial part about this PR is the swapping of I think we should merge this PR sometime and then push a release. Or maybe we can sneak in that neovim change too :^) |
217a0c7
to
2644c78
Compare
Cooperating with this PR: #1712
I did a lot of refactoring of the repeating motions. I initially did it to try and fix
gbb
and surround easier, but it turns out that our current system is actually unsound. It relies on the order that @RegisterAction pushes actions into the list, which we have not specified any guarantees about.I also switched
gc
andgb
around, for two reasons. For one,gc
is the actual keybinding used by the commenting plugin. Number two,gbb
is not a sound keybinding. Are we executinggb
over the range ofb
? Or are doing thegcc
command?Yes, I realize that this might screw up what some people are used to, but I think it's worth it, for the philosophical soundness :)
As per discussion with @johnfn, I added an annoying error message everytime somebody tries to use "gb" or "gc", as well as a setting to disable those messages. The plan is to have those annoying messages until a couple weeks later, when we can remove them.
In the process of refactoring the repeating motions, I also fixed some other isssues (and another regression actually).
Fixes #1534, fixes #1518, fixes #1716, fixes #1618, fixes #1450.