Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1534, #1518, #1716, #1618, #1450: Refactored repeating motions #1712

Merged
merged 21 commits into from
May 22, 2017

Conversation

Chillee
Copy link
Member

@Chillee Chillee commented May 18, 2017

I did a lot of refactoring of the repeating motions. I initially did it to try and fix gbb and surround easier, but it turns out that our current system is actually unsound. It relies on the order that @RegisterAction pushes actions into the list, which we have not specified any guarantees about.

I also switched gc and gb around, for two reasons. For one, gc is the actual keybinding used by the commenting plugin. Number two, gbb is not a sound keybinding. Are we executing gb over the range of b? Or are doing the gcc command?

Yes, I realize that this might screw up what some people are used to, but I think it's worth it, for the philosophical soundness :)

As per discussion with @johnfn, I added an annoying error message everytime somebody tries to use "gb" or "gc", as well as a setting to disable those messages. The plan is to have those annoying messages until a couple weeks later, when we can remove them.

In the process of refactoring the repeating motions, I also fixed some other isssues (and another regression actually).

Fixes #1534, fixes #1518, fixes #1716, fixes #1618, fixes #1450.

@Chillee Chillee changed the title WIP: Refactored repeating motions Refactored repeating motions May 18, 2017
@Chillee Chillee changed the title Refactored repeating motions Fixes #1534: Refactored repeating motions May 18, 2017
@Chillee Chillee changed the title Fixes #1534: Refactored repeating motions Fixes #1534, #1518: Refactored repeating motions May 18, 2017
@Chillee Chillee changed the title Fixes #1534, #1518: Refactored repeating motions Fixes #1534, #1518, #1716: Refactored repeating motions May 18, 2017
@Chillee Chillee changed the title Fixes #1534, #1518, #1716: Refactored repeating motions Fixes #1534, #1518, #1716, #1618: Refactored repeating motions May 18, 2017
@Chillee Chillee changed the title Fixes #1534, #1518, #1716, #1618: Refactored repeating motions Fixes #1534, #1518, #1716, #1618, #1450: Refactored repeating motions May 19, 2017
@Chillee
Copy link
Member Author

Chillee commented May 21, 2017

I think this is another PR that's ready. Only controversial part about this PR is the swapping of gb and gc. However, I've added a loud Error notification when the user uses any of the 2, saying that gb and gc have been swapped, as well as telling them that there's a setting that disables it.

I think we should merge this PR sometime and then push a release. Or maybe we can sneak in that neovim change too :^)

@Chillee Chillee force-pushed the repeatedfix branch 2 times, most recently from 217a0c7 to 2644c78 Compare May 21, 2017 23:48
@Chillee Chillee merged commit c4462b5 into VSCodeVim:master May 22, 2017
Chillee added a commit that referenced this pull request May 23, 2017
Cooperating with this PR: #1712
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant