Fixes #1655: Extends gf to line numbers #1708
Conversation
src/cmd_line/commands/file.ts
Outdated
| @@ -85,6 +86,19 @@ export class FileCommand extends node.CommandBase { | |||
| let folder = vscode.Uri.file(newFilePath); | |||
| await vscode.commands.executeCommand("vscode.open", folder, | |||
| this._arguments.position === FilePosition.NewWindow ? this.getViewColumnToRight() : this.getActiveViewColumn()); | |||
|
|
|||
| await vscode.commands.executeCommand("cursorMove", { | |||
There was a problem hiding this comment.
How do we handle the :50 command? This should be done the same way, this hack should not be necessary for sure... There should also be a vscode command to go to line
There was a problem hiding this comment.
Can we do :50 to open a new file?
There was a problem hiding this comment.
No, go to line. The file action looks good to me, then jumping to the right line needs to be cleaned up
There was a problem hiding this comment.
It's no problem to do :50 in the same file, as we can just move the cursor ourselves. The problem is that once we call the API to open a new file, we don't have access to the new modeHandler yet, in this file.
Come to think of it though, there was another part of the code where we might have needed to do something similar. I'll take a look at that later.
There was a problem hiding this comment.
What about a vscode command to go to line?
src/cmd_line/commands/file.ts
Outdated
|
|
||
| if (this.arguments.lineNumber) { | ||
| vscode.window.activeTextEditor!.revealRange(new vscode.Range(new vscode.Position(this.arguments.lineNumber, 0), new vscode.Position(this.arguments.lineNumber, 0))); | ||
| } |
There was a problem hiding this comment.
I guess this is probably better?
|
Thanks! |
Pretty simple, mostly. One thing to note is that I'm not sure what's the best way of setting cursor position after we change files. Any ideas?
Link to the regex used