Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(surround): support complex tags surround #1680

Merged
merged 2 commits into from
May 10, 2017

Conversation

admosity
Copy link
Contributor

@admosity admosity commented May 10, 2017

Fixes issue with complex tag surround by only including the actual tag name instead of the whole contents of the tag.

Before:
image

After:
image

Couldn't find any tests written for surround... So no tests. If someone lets me know where I should put tests for this; I'll update the PR.

@xconverge
Copy link
Member

let me add a few surround tests real quick, then you can add yours there! :)

@xconverge
Copy link
Member

There you go, could you add one or two to test/plugins/surround.test.ts

Thanks!

@admosity
Copy link
Contributor Author

Thanks! Updated.

@xconverge xconverge merged commit 96ecbdf into VSCodeVim:master May 10, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants