Fix visual mode activated on insert mode #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,6 +40,9 @@ export class VisualMode extends Mode { | |||
| } | |||
|
|
|||
| shouldBeActivated(key: string, currentMode: ModeName): boolean { | |||
| if (currentMode !== ModeName.Normal) { | |||
| return false; | |||
| } | |||
| return key === "v"; | |||
There was a problem hiding this comment.
I think it's simpler if you do this:
return key === "v" && currentMode === ModeName.Normal
Can you also add in the modeNormal.ts that is you are in Visual Mode and v is entered, it should go to Normal Mode?
There was a problem hiding this comment.
Whoa, been using vim for ages and never knew that v in visual mode brings you out of visual mode!
There was a problem hiding this comment.
I'm in the same boat -- learning a lot of little things here and there building out this extension.
|
@jpoon yeah let me revise it. Later today I will push some changes. |
jpoon
added a commit
that referenced
this pull request
Mar 1, 2016
Fix visual mode activated on insert mode
|
Thanks @frarees |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.