Fixes #1503: Undo history isn't kept when switching tabs #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah that is weird and probably should be investigated further. This is good to go though? No bad conflict with e.g. gd I assume? :) |
|
It all seems to work for me. gd works properly, undo history seems to work even when switching files, whether it's from gd or ctrl+tab. After playing around with it for 5 minutes or so, I couldn't get it to break, so I think it's good to go. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that whenever we switch editors, we don't have access to cursorPosition until after the stack clears?
Whatever it is, it's similar to this PR: #1605