Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1441: Ctrl-c dropping a character when selecting from right to left in insert mode #1628

Merged
merged 2 commits into from
May 4, 2017

Conversation

Chillee
Copy link
Member

@Chillee Chillee commented May 2, 2017

In insert mode, selecting from left to right results in one more character being selected, so our old workaround was to shift the end of the selection to the left if we're in insert mode.

So this is how the cursor selections look when we're in "".
In Normal mode dragging from left to right or right to left,
"|fooba|r"
In Insert mode dragging from left to right,
"|foobar|"
In Insert mode dragging from right to left,
"|fooba|r"

Thus, it works normally if we're selecting from right to left.

Also fixes #1355

@xconverge
Copy link
Member

Thanks, since this was special cased already it LGTM

@xconverge xconverge merged commit 4c9fdb1 into VSCodeVim:master May 4, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copying backwards in insert mode doesn't work.
2 participants