Fixes #1137: i_<C-w> deletes through whitespace at beginning of line #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chillee
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was really really hoping we could reuse code from 'diw' or something like that, but basically, this is the behavior we want from .
Get the closest to you of either the beginning of the line or the beginning of the first word to the left of your current position (including your current word if you're on a word), or a newline.
It doesn't really fit well into how we're handling word boundaries anywhere else.
I also added a position utility function to determine whether the current position is in leading whitespace of a line.
Speaking of which, we really need to explain what some of our utility functions do. A lot of them are pretty self explanatory, but one that keeps tripping me up is
position.getLastWordEnd()Failed tests are not this PR's issue (pretty sure).