Fixes #1196, #1197: d}/y} not working correctly #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chillee
commented
May 1, 2017
| @@ -1256,11 +1256,7 @@ export class ModeHandler implements vscode.Disposable { | |||
| } | |||
|
|
|||
| if (!cachedMode.isVisualMode && cachedRegister !== RegisterMode.LineWise) { | |||
| if (Position.EarlierOf(start, stop) === start) { | |||
There was a problem hiding this comment.
This is a bizarre if condition, considering that we set start to the earlier of [start, stop], unless start is equal to stop.
Chillee
changed the title
|
If you say this is good to go then I am good with merging it. :) |
|
Lemme add a couple more integration tests, and then it should be good to go. Thanks! |
|
Alright repushed my tests (that I didn't push before). This should be good to go! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1196, which was a lot harder than it seemed. I also refactored a tiny part of modeHandler that made it very difficult/impossible to fix this.
I also fixed #1197
However, the fix also actually broke a test, but I think it actually broke the test so it actually has correct behavior now! I've committed the test I changed as well.